build: support Apple Silicon macOS - #96
Draft
EmilGH wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root causes addressed
The legacy build used names now provided by the macOS SDK, removed Boost.Filesystem APIs,
std::random_shuffle, Python APIs removed in Python 3, and deployment assumptions that no longer match current Homebrew Qt frameworks and dylibs.The scrypt change only namespaces Garlicoin's local endian helper functions to avoid SDK symbol collisions. The wallet shuffle remains Fisher-Yates and continues to use Garlicoin's existing RNG. No wallet serialization or database-format code is changed.
Validation
make -j8completes successfullyGarlicoin-Qt.apppasses strict deep signature verificationGarlicoin-Qt.dmgpasseshdiutil verifymake checkbuilds the complete core and Qt test binaries but the inherited suite is not currently green: the core runner reports 225 failures, and four Qt groups fail. The failures include stale Litecoin address/hash/amount fixtures, an expired payment-test certificate, and cascading ECC fixture assertions. Focused tests covering the compatibility changes above pass; this PR intentionally does not broaden into rewriting unrelated historical fixtures.Compatibility and release notes